-
Notifications
You must be signed in to change notification settings - Fork 0
Fix control node handles & context menu #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
anila-m
wants to merge
23
commits into
main
Choose a base branch
from
fix/control-node-handles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anila-m
commented
Oct 30, 2025
- input & output handles for if-else node and repeat node are fixed (at most one final output per input)
- number of inputs (and outputs) can be increased and decreased with the context menu for the following nodes:
- If-else
- repeat
- merger
- splitter
- (classical) algorithm
number of input handles now determined by parameter (in property panel), not by number of connected handles. Not completely fixed for if-then-else node.
- Final Output handles (polygon on the right) appear when internal output handles (then and else blocks) are connected. - position of final output handles fixed
added some comments
Added buttons to add and remove input/output for some nodes, wherever applicable. - if-then-else & repeat: add/remove quantum/classical input - merger: add/remove input - splitter: add/remove output
Added submenu if node has both classical and quantum input, i.e. Add Input > Quantum | Classical.
Changed "Classic" to "Classical" in Submenu of Context Menu.
Maximum one final output handle per input.
- algorithm nodes (classical & quantum) now have data fields numberQuantumInputs/Outputs and numberClassicalInputs/Outputs - values can be changed in property panel and via context menu - preparation for consolidating algorithm and classicalAlgorithm into one node
using property panel to change number of inputs and outputs of custom (quantum/classical) operator fixed. Context menu: adding/removing input/output fixed.
Uniform setting specifiers for experience mode, recommended settings (table) and configuration: * Ancilla Modeling: On/Off * Compact Visualization: On/Off * Completion Guaranteed: Yes/No
Property Panel now shows all choices of arithmetic operators if completionGuaranteed == False.
Categories "Data Types" and "Operators" have different descriptions based on completionGuaranteed
Automatically sets recommended settings when switching Experience levels: * Explorer: Ancilla Off, Compact Off * Pioneer: Ancilla On, Compact On
Changed filename from "reactflow-diagram.svg" to "[model name]_flow-[id].svg"
category panel: moved TDG gate up to T gate
* Remove Input/Output only appears in context menu if there are inputs/outputs to be removed * custom classical operator: only cassical inputs/outputs, minimum number of in/out: 0 * custom quantum operator: both classical and quantum, minimum number of in/out: 0 * merger and splitter: minimum number of in/out: 2 * control structure nodes: minimum number of inputs: 1
added classical inputs & outputs for custom quantum operator
error: deleting custom classical/quantum operator node threw error (white screen).
* side panels open at the beginning * experience mode panel opens only for relevant steps * correct property panel visible (property panel of selected node instead of model information
* switching experience level sets default setting (Ancilla Mode and Compact Visualization)
* removed "numberInputs" fields (and similar fields) for Splitter, Merger, Custom Operators, Control Structure Nodes * inputs in property panel didn't work, need to be fixed before input fields are added again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.